[cfe-commits] r158229 - /cfe/trunk/lib/Frontend/TextDiagnostic.cpp

Matt Beaumont-Gay matthewbg at google.com
Fri Jun 8 14:29:35 PDT 2012


On Fri, Jun 8, 2012 at 2:24 PM, Chandler Carruth <chandlerc at google.com> wrote:
> On Fri, Jun 8, 2012 at 2:22 PM, Jordan Rose <jordan_rose at apple.com> wrote:
>>
>>
>> On Jun 8, 2012, at 14:21 , Chandler Carruth <chandlerc at google.com> wrote:
>>
>> On Fri, Jun 8, 2012 at 2:14 PM, Jordan Rose <jordan_rose at apple.com> wrote:
>>>
>>> Author: jrose
>>> Date: Fri Jun  8 16:14:19 2012
>>> New Revision: 158229
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=158229&view=rev
>>> Log:
>>> If fixits appear to overlap, move the second one over in the output.
>>>
>>> This occurs when you have two insertions and the first one is so long
>>> that the
>>> second fixit's column is before the first fixit ends. The edits
>>> themselves
>>> don't actually overlap, but our command-line preview does.
>>
>>
>> Can you use FileCheck to write a test case please?
>>
>>
>> Sorry, I couldn't think of one besides the case in r158230 and then forgot
>> to go back and do it. Thanks for the reminder.
>
>
> Matt, you've seen this a bit. Can you provide a simple test case?

http://lists.cs.uiuc.edu/pipermail/cfe-dev/2011-August/016685.html
http://llvm.org/bugs/show_bug.cgi?id=10696

(h/t dblaikie)

-Matt




More information about the cfe-commits mailing list