[cfe-commits] r158180 - in /cfe/trunk: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp test/Analysis/inline-plist.c test/Analysis/malloc-plist.c test/Analysis/plist-output-alternate.m test/Analysis/plist-output.m

[Anna Zaks]

On Jun 7, 2012, at 5:44 PM, Jordan Rose wrote:

> Nice!
> 
> Possible next step: lines from beginning of function. That ignores simple fixes if there are other errors earlier.

My commit message was not very clear. This IS adding offset (num of lines) from the beginning of the enclosing function.
> 
> On Jun 7, 2012, at 17:04 , Anna Zaks <ganna at apple.com> wrote:
> 
>> Author: zaks
>> Date: Thu Jun  7 19:04:43 2012
>> New Revision: 158180
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=158180&view=rev
>> Log:
>> [analyzer] Add experimental "issue hash" to the plist diagnostic.
>> 
>> CmpRuns.py can be used to compare issues from different analyzer runs.
>> Since it uses the issue line number to unique 2 issues, adding a new
>> line to the beginning of a file makes all issues in the file reported as
>> new. 
>> 
>> The hash will be an opaque value which could be used (along with the
>> function name) by CmpRuns to identify the same issues. This way, we only
>> fail to identify the same issue from two runs if the function it appears
>> in changes (not perfect, but much better than nothing).
>> 
>> Modified:
>>   cfe/trunk/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
>>   cfe/trunk/test/Analysis/inline-plist.c
>>   cfe/trunk/test/Analysis/malloc-plist.c
>>   cfe/trunk/test/Analysis/plist-output-alternate.m
>>   cfe/trunk/test/Analysis/plist-output.m
>