[cfe-commits] TableGen backend API refactoring review request

Jakob Stoklund Olesen stoklund at 2pi.dk
Wed Jun 6 13:42:25 PDT 2012

On Jun 4, 2012, at 11:34 PM, Sean Silva <silvas at purdue.edu> wrote:

> The two attached patches change the TableGen backend API (of LLVM and clang respectively). They are git diff'd against current ToT. They must both be applied "atomically" because the Clang changes depend on LLVM header changes (is there a way to avoid this problem without leaving in the old code in with a "don't touch, will be removed soon" comment?).

Please try to avoid revlock like that. You can just leave struct TableGenBackend around until it isn't used any longer.

Also, split the changes to lib/TableGen and include/llvm/TableGen into a third patch.

> I'm in the air about where to declare the backends namespacewise. In the LLVM TableGen (which I converted first), I decided to put all the backends inside a namespace "tblgen_backends" inside namespace llvm, which turns out to be a pain in the ass.

There's really no need for that. Backends don't go in libraries. Just stick everything in 'llvm'.

> Another area that I have questions is whether the filenames should be changed, since they are all called FooEmitter.cpp, but sometimes a class FooEmitter doesn't exist anymore. My general feeling is that it doesn't really matter, so best to just leave them. This is easily changed in a future patch if it is deemed desirable.

Leave them as is.


More information about the cfe-commits mailing list