[cfe-commits] [patch] Mention "put ambiguous fixits on notes" in internals manual

Nico Weber thakis at chromium.org
Mon Jun 4 12:55:27 PDT 2012

Please take another look.

On Mon, Jun 4, 2012 at 11:41 AM, Richard Smith <richard at metafoo.co.uk>wrote:

> On Mon, Jun 4, 2012 at 10:51 AM, David Blaikie <dblaikie at gmail.com> wrote:
> >> several threads on this list discussed that fixits on errors and
> warnings
> >> have to be very likely correct. "did you mean" fixits on the other hand
> >> should go on a separate note instead. The attached patch adds this to
> the
> >> internals manual.
> >
> >
> > Looks reasonable (I think you can take my opinion as approval in this
> case -
> > but I guess you sent it out for review looking for other feedback too,
> > perhaps). If it interests you, it's probably also worth highlighting the
> > "recover as written" requirement which isn't entirely clear/explicit in
> > those docs (and the implication that has on fixits on warnings: that they
> > cannot change semantics - they have to be the "suppression" fix at most
> > (which means there are very few cases where fixits on warnings are valid
> > (since if you're confident the warning is good then the chances are that
> the
> > suppression is not the right fix)))
> +1. I think that the statement in the patch that "[...] warnings
> should only have fix-its that very likely match the user's intent" is
> likely to mislead people if we don't also document the "recover as
> written" requirement.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120604/8ad7f87b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixit-docs.diff
Type: application/octet-stream
Size: 1112 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120604/8ad7f87b/attachment.obj>

More information about the cfe-commits mailing list