[cfe-commits] r157890 - /cfe/trunk/unittests/Tooling/ToolingTest.cpp

[Alexander Kornienko]

Hi,

On Sat, Jun 2, 2012 at 5:34 PM, NAKAMURA Takumi <geek4civic at gmail.com>wrote:

> Author: chapuni
> Date: Sat Jun  2 10:34:26 2012
> New Revision: 157890
>
> URL: http://llvm.org/viewvc/llvm-project?rev=157890&view=rev
> Log:
> Revert r157819, "#ifdef out a broken test on win32"
>
> FYI, LLVM_ON_WIN32 is useless.
>
> Modified:
>    cfe/trunk/unittests/Tooling/ToolingTest.cpp
>
> Modified: cfe/trunk/unittests/Tooling/ToolingTest.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Tooling/ToolingTest.cpp?rev=157890&r1=157889&r2=157890&view=diff
>
> ==============================================================================
> --- cfe/trunk/unittests/Tooling/ToolingTest.cpp (original)
> +++ cfe/trunk/unittests/Tooling/ToolingTest.cpp Sat Jun  2 10:34:26 2012
> @@ -110,9 +110,6 @@
>   EXPECT_TRUE(Action.get() != NULL);
>  }
>
> -#ifndef LLVM_ON_WIN32
> -// This test breaks on Windows.
> -
>  TEST(ToolInvocation, TestMapVirtualFile) {
>   clang::FileManager Files((clang::FileSystemOptions()));
>   std::vector<std::string> Args;
> @@ -126,7 +123,5 @@
>   EXPECT_TRUE(Invocation.run());
>  }
>
> -#endif
> -
>  } // end namespace tooling
>  } // end namespace clang
>

Does this test still break on windows?

-- 
Best regards,
Alexander Kornienko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120604/73cf285e/attachment.html>