[cfe-commits] [PATCH] Fixed built-in headers resolution related problem in clang/Tooling

Manuel Klimek klimek at google.com
Mon Jun 4 12:04:33 PDT 2012


LGTM

On Mon, Jun 4, 2012 at 9:02 PM, Alexander Kornienko <alexfh at google.com>wrote:

> There it is.
>
> On Mon, Jun 4, 2012 at 8:47 PM, Manuel Klimek <klimek at google.com> wrote:
>
>> Since we're now requiring the users of ToolInvocation to know about
>> builtin include paths being dependent on the argv[0] I think we should
>> document that on ToolInvocation.
>>
>> Cheers,
>> /Manuel
>>
>>
>> On Mon, Jun 4, 2012 at 8:44 PM, Alexander Kornienko <alexfh at google.com>wrote:
>>
>>> Hi,
>>>
>>> This patch fixes a problem related to resolution of built-in headers in
>>> case a path of tool's binary contains sym-links.
>>> Please, review it. Thanks!
>>>
>>> --
>>> Best regards,
>>> Alexander Kornienko
>>>
>>
> --
> Regards,
> Alex
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120604/134f9fcf/attachment.html>


More information about the cfe-commits mailing list