[cfe-commits] [patch] Mention "put ambiguous fixits on notes" in internals manual

David Blaikie dblaikie at gmail.com
Mon Jun 4 10:51:45 PDT 2012

> several threads on this list discussed that fixits on errors and warnings
> have to be very likely correct. "did you mean" fixits on the other hand
> should go on a separate note instead. The attached patch adds this to the
> internals manual.

Looks reasonable (I think you can take my opinion as approval in this case
- but I guess you sent it out for review looking for other feedback too,
perhaps). If it interests you, it's probably also worth highlighting the
"recover as written" requirement which isn't entirely clear/explicit in
those docs (and the implication that has on fixits on warnings: that they
cannot change semantics - they have to be the "suppression" fix at most
(which means there are very few cases where fixits on warnings are valid
(since if you're confident the warning is good then the chances are that
the suppression is not the right fix)))

- David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120604/f4ba6277/attachment.html>

More information about the cfe-commits mailing list