[cfe-commits] Support Android standalone toolchain in Clang driver

Benjamin Kramer benny.kra at googlemail.com
Mon Jun 4 08:11:34 PDT 2012


On 04.06.2012, at 17:00, Evgeniy Stepanov wrote:

> Hi,
> 
> this patch adds detection of C++ headers and libraries paths when
> building with the standalone toolchain from Android NDK. They are in a
> slightly unusual place.
> 
> Please review.

> const Twine IncludePathCandidates[] = {

You can't store an array of Twines. The class relies on temporary objects which are destroyed at the end of the statement. The compiler can chose to reallocate the memory of the temporary and your code will fail.

- Ben
> <android-standalone.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits





More information about the cfe-commits mailing list