[cfe-commits] r157593 - /cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h

Benjamin Kramer benny.kra at googlemail.com
Mon May 28 14:01:59 PDT 2012


Author: d0k
Date: Mon May 28 16:01:59 2012
New Revision: 157593

URL: http://llvm.org/viewvc/llvm-project?rev=157593&view=rev
Log:
Fix suspicous isIntegerType() check, found by PVS Studio (PR12357).

Modified:
    cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h

Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h?rev=157593&r1=157592&r2=157593&view=diff
==============================================================================
--- cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h (original)
+++ cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h Mon May 28 16:01:59 2012
@@ -78,7 +78,7 @@
     // FIXME: Remove the second disjunct when we support symbolic
     // truncation/extension.
     return (Context.getCanonicalType(Ty1) == Context.getCanonicalType(Ty2) ||
-            (Ty2->isIntegerType() && Ty2->isIntegerType()));
+            (Ty1->isIntegerType() && Ty2->isIntegerType()));
   }
 
   SVal evalCast(SVal val, QualType castTy, QualType originalType);





More information about the cfe-commits mailing list