[cfe-commits] r157445 - /cfe/trunk/lib/Frontend/TextDiagnostic.cpp

[Joerg Sonnenberger]

On Thu, May 24, 2012 at 05:50:00PM -0700, Marshall Clow wrote:
> On May 24, 2012, at 5:03 PM, Seth Cantrell wrote:
> 
> > Author: socantre
> > Date: Thu May 24 19:03:29 2012
> > New Revision: 157445
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=157445&view=rev
> > Log:
> > ensure value passed to is space is representable as unsigned char
> 
> Note that in C++ you can use the current facet which has a templated
> isspace function, so you don't have to use the C 'isspace'. (with all
> its' limitations)
> 
> namespace std {
> 	template <class charT> bool isspace (charT c, const locale& loc);
> 	};

Which version of C++ are you thinking about? This looks strongly like
depending on xlocale, which would seriously limit portability...

Joerg