[cfe-commits] r157331 - in /cfe/trunk: include/clang/Tooling/Refactoring.h lib/Tooling/CMakeLists.txt lib/Tooling/Refactoring.cpp unittests/CMakeLists.txt unittests/Tooling/RefactoringTest.cpp

[Manuel Klimek]

On Wed, May 23, 2012 at 8:02 PM, Jordan Rose <jediknil at belkadan.com> wrote:

> Sorry for late review...I know this has been living as a patch for a
> while. One small comment:
>
> On May 23, 2012, at 12:29, Manuel Klimek wrote:
> > +  /// \brief Accessors.
> > +  /// @{
> > +  std::string getFilePath() const { return FilePath; }
>
> How about StringRef here? Avoids the copy in the case where it's going to
> be used read-only.
>

Done in r157387. Thx for the review.
/Manuel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120524/61c1fb02/attachment.html>