[cfe-commits] [PATCH] clang/test/Tooling: Tweaks for Win32 hosts

Manuel Klimek klimek at google.com
Wed May 23 01:17:30 PDT 2012


First, a big thanks for helping with this stuff!

Two nits:
- the change to PathV2 looks like it could need a test
- SmallString<8> looks like it would basically never hit the small case for
paths, I'd probably got with 128

Apart from that, looks good.

Cheers,
/Manuel

On Wed, May 23, 2012 at 2:50 AM, NAKAMURA Takumi <geek4civic at gmail.com>wrote:

> They could pass also on msvc if they were -fms-compatibility tolerant.
>
> Manuel, I would be happier if you could tweak tests with -target
> i686-win32.
>
> ---
> clang/lib/Tooling/CompilationDatabase.cpp | 8 ++++++--
> clang/lib/Tooling/Tooling.cpp | 8 ++++++--
> clang/test/Tooling/clang-check-builtin-headers.cpp | 2 +-
> clang/test/Tooling/clang-check-chdir.cpp | 2 +-
> clang/test/Tooling/clang-check-pwd.cpp | 2 +-
> clang/test/Tooling/clang-check.cpp | 2 +-
> llvm/lib/Support/PathV2.cpp | 3 +++
> 7 files changed, 19 insertions(+), 8 deletions(-)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120523/036851b3/attachment.html>


More information about the cfe-commits mailing list