[cfe-commits] [PATCH] Add analyzer_assert for regression tests

[Ted Kremenek]

On May 15, 2012, at 12:21 PM, Anna Zaks <ganna at apple.com> wrote:

> 
> 5) This one is the most important. I'd only change the test cases where you are absolutely sure that the constraint solver is the only thing that's being tested there and leave the rest. It is OK to have both types of tests and we don't want to decrease our coverage of testing for actual warnings. I see this enhancement as simplifying addition of this type of tests in the future; we don't need to convert all our tests to using it.

Just catching up on this.

Overall, I think this is great.  I agree very much with this point, however.  We still want to keep tests, particularly those in misc-ps-X and friends, that test path sensitivity explicitly, to do what they are already doing.  Sometimes we lose path sensitivity because we break live variables analysis, etc., and changing the structure of the code itself in a test case will make it less useful.  I agree that we should mainly use this when we are explicitly testing the constraint solver, and not when we are testing how specific paths are actually executed (if that is the important part of the test).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120522/f20e99cd/attachment.html>