[cfe-commits] [PATCH] Use more general inline asm register constraints in tests

[Erik Verbruggen]

On May 21, 2012, at 10:23, Simon Atanasyan wrote:

> Hi,
> 
> The following two test cases from clang test suite are failed on MIPS:
> 
> Analysis/nullptr.cpp
> CodeGen/Generic/asm-large-immediate.ll
> 
> The reason is inline asm constraint "=a" (means %eax, %ax, %al) used
> in these tests. This constraint is unsupported on MIPS. I think this
> constraint can be safely replaced by the more general one "=r" (means
> any general purpose register). The attached patch does that for both
> test cases.
> 
> Are there any objections?

No, the sole purpose of these tests is to see if those warnings occur. Whatever the constriant: if they do, then fine (first file is a (known) bug). So if this works for non-mips platforms, then go ahead and commit.

-- Erik.