[cfe-commits] [libcxx] r157128 - /libcxx/trunk/include/memory

Howard Hinnant hhinnant at apple.com
Sat May 19 13:20:49 PDT 2012

Author: hhinnant
Date: Sat May 19 15:20:49 2012
New Revision: 157128

URL: http://llvm.org/viewvc/llvm-project?rev=157128&view=rev
Revert fix to http://llvm.org/bugs/show_bug.cgi?id=12867 for the reason now included in the code comment.


Modified: libcxx/trunk/include/memory
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/memory?rev=157128&r1=157127&r2=157128&view=diff
--- libcxx/trunk/include/memory (original)
+++ libcxx/trunk/include/memory Sat May 19 15:20:49 2012
@@ -3603,9 +3603,10 @@
     long use_count() const _NOEXCEPT {return __shared_count::use_count();}
     __shared_weak_count* lock() _NOEXCEPT;
-#ifndef _LIBCPP_NO_RTTI
+    // purposefully not protected with #ifndef _LIBCPP_NO_RTTI because doing so
+    //  breaks ABI for those clients who need to compile their projects with
+    //    -fno-rtti and yet link against a libc++.dylib compiled without -fno-rtti.
     virtual const void* __get_deleter(const type_info&) const _NOEXCEPT;
     virtual void __on_zero_shared_weak() _NOEXCEPT = 0;

More information about the cfe-commits mailing list