[cfe-commits] [libcxx] r157049 - /libcxx/trunk/include/memory
dblaikie at gmail.com
Fri May 18 10:54:30 PDT 2012
On Fri, May 18, 2012 at 10:46 AM, Howard Hinnant <hhinnant at apple.com> wrote:
> On May 18, 2012, at 10:49 AM, John McCall wrote:
>> On May 18, 2012, at 6:06 AM, Howard Hinnant wrote:
>>> Author: hhinnant
>>> Date: Fri May 18 08:06:21 2012
>>> New Revision: 157049
>>> URL: http://llvm.org/viewvc/llvm-project?rev=157049&view=rev
>>> Protect __shared_weak_count::__get_deleter declaration with _LIBCPP_NO_RTTI. Fixes http://llvm.org/bugs/show_bug.cgi?id=12867
>> Is this not just reverting r140907, your fix to rdar://problem/10217868? Commenting out virtual method declarations breaks ODR in a very significant way.
> Thanks John. I'll revert this and put in a comment so I don't make this mistake again. Can't do it now, boarding plane….
Perhaps a test case would be handy?
More information about the cfe-commits