[cfe-commits] [PATCH] "missing argument" diagnostic should include argument name

[Terry Long]

> The patch generally looks good, thanks!

Great, thanks for the feedback.

> Presumably this only applies to the case where there are no arguments, because otherwise we couldn't know /which/ argument was missing?

Yes, only for the case where there are no arguments to a function that takes 1 argument. Almost impossible to determine the missing argument(s) otherwise.

> 
> Please add test coverage for the err_typecheck_call_too_few_args_at_least_one diagnostic. Also, NamedDecl::getNameAsString is deprecated; please just use "<< FDecl->getParamDecl(0)", and use getParamDecl(0)->getDeclName()'s operator bool() in the test, rather than empty().

OK, I'll update this. I was using the online doxygen docs and didn't see any deprecation warnings. Anywhere where I can find that information?

> 
> It would also be great to extend this to the 'candidate function not viable' diagnostics in C++.

I can take a look at this too.


-Terry