[cfe-commits] [PATCH] X-TU Refactoring support

Chandler Carruth chandlerc at google.com
Fri May 4 00:02:31 PDT 2012

On Thu, May 3, 2012 at 11:10 AM, Manuel Klimek <klimek at google.com> wrote:

> So return bool and use and unsigned reference to return the value?

Actually, I don't understand what the '-1' really has to do with getting
the range's size? Maybe it needs more comments explaining its contract?

My main concern with moving that right now is that we recently
> discovered that this might not be the right solution yet to create a
> replacement from an AST node - we'll probably want to drill through
> macros and find the right point inside the expansion closest to the
> spelling where the full node is expressed.
> I've looked at makeFileCharRange in the Lexer, which seemed related at
> a first glance, but I have no idea what it really does :)
> My problem is currently that I could need some ideas on what to do
> here, as the general case seems really hard to implement and I'm a
> little lost.

FWIW, if it's still in flux, I think it makes fine since to keep locally
with a FIXME comment that once we understand the correct interface, it
should move to the lexer. We don't need to do that eagerly it seems.
(Hoping to unblock this particular patch, so work on this can proceed
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120504/9fc1522f/attachment.html>

More information about the cfe-commits mailing list