[cfe-commits] [PATCH] Fix test case failure due to C++ ABI difference on ARM

John McCall rjmccall at apple.com
Wed May 2 18:35:43 PDT 2012

On May 2, 2012, at 1:11 AM, 陳韋任 wrote:
>>> Okay, I see the test done by virt-call-offsets.cpp is moved to member-function-pointers.cpp.
>>> Do you know what the fix on X86/ARM ctor ABI difference status is [1]?
>> virt-call-offsets.cpp was not expecting to be tested on an ARM host.  That's
>> a legitimate flaw in the test, but it does not indicate a bug in our handling of
>> the ARM C++ ABI.  I implemented returning this from ctors and dtors on
>> ARM targets in August 2010 in r112588, and as far as I know, there is nothing to fix.
>  I know the ARM C++ ctor ABI is handled correctly. :) Actually I want to know
> the status of the patch [1] which change the matching rule from
> // CHECK: call void @_ZN10destroyme1D1Ev
> to 
> // CHECK: call {{.*}}* @_ZN10destroyme1D1Ev
>  I don't see they are applied in the trunk.

Sorry!  I completely misunderstood.  You're right that this test just needed
a triple, but it also doesn't need to be an independent test;  I rolled it into
x86_64-arguments.cpp in r156047, thanks!


More information about the cfe-commits mailing list