[cfe-commits] [Patch] [PythonBindings] Exposing cursor semantic and lexical parent to python (now with proper tests)

[Evan Pipho]

I am assuming you meant my comments for get_cursors in the test utils.  If
so, fixed.


On Wed, May 2, 2012 at 10:23 AM, Manuel Klimek <klimek at google.com> wrote:

> Looks good.
>
> Very minor nit: Comments are easier to read (IMO) if you're adding a
> '.' when you have a full sentence.
>
> On Tue, May 1, 2012 at 7:37 AM, Evan P <hiwrac at gmail.com> wrote:
> > When I was writing tests for the original version of this patch I
> discovered
> > that clang_getCursorLexicalParent was actually broken for some edge
> cases.
> > Now that my patch for that issue was committed in r155858, lets try this
> > again.
> >
> > - Adding lexical_parent and semantic_parent properties to
> > clang.cindex.Cursor
> > - Two new tests (one for each property), require libclang built from
> r155858
> > or later to pass
> > - New test utility function (get_cursors) that gets all the nodes with a
> > specific spelling.
> >
> >
> > Thanks
> > -Evan Pipho
> >
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120502/25822d0b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: python_cursor_parents.patch
Type: application/octet-stream
Size: 4156 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120502/25822d0b/attachment.obj>