[cfe-commits] Request for approval: Pythonstuff including Cursor.enum_value

Chandler Carruth chandlerc at google.com
Wed May 2 02:33:05 PDT 2012

On Wed, May 2, 2012 at 2:17 AM, Manuel Klimek <klimek at google.com> wrote:

> those patches have much better chances of being reviewed (at least by
> me) if you:
> - split them into one mail per patch

Just to avoid confusion on this front, as I feel like I may have given
contradictory advice here, let me briefly elaborate...

Sending one mail with N patches *on a particular topic* is better than
simultaneously sending N mails with N patches... However, if the contents
of each patch are largely unrelated, that's no-longer the case. In this
case, it seems like the last two patches are the only two closely related;
i would keep those grouped in a single mail.

However, better still is to send each individual patch in its own email
thread the moment it's ready rather than batching them up. This avoids
hitting folks with a pile of reviews all at once and generally works better
with the way the community reviews patches.

Anyways, I'll go back to the corner now, as I know nothing about Python. =]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120502/a6319e65/attachment.html>

More information about the cfe-commits mailing list