[cfe-commits] [PATCH] Driver: Unify CC1Options.td and Options.td, take 2!

James Molloy james.molloy at arm.com
Tue May 1 00:39:46 PDT 2012

Hi Doug,

Thanks! :) The only reason I haven't committed it yet given Eric's "LGTM" is
that Chandler is currently reviewing it as a trial of the review board
system here:

When he OK's it, I'll commit it.



-----Original Message-----
From: Douglas Gregor [mailto:dgregor at apple.com] 
Sent: 01 May 2012 01:04
To: James Molloy; Chandler Carruth
Cc: cfe-commits at cs.uiuc.edu cfe; Joerg Sonnenberger
Subject: Re: [cfe-commits] [PATCH] Driver: Unify CC1Options.td and
Options.td, take 2!

I like this a *lot*. Go for it.

	- Doug

On Apr 23, 2012, at 4:14 AM, James Molloy <James.Molloy at arm.com> wrote:

> Hi,
> Could someone please review this? :(
> Cheers,
> James
> -----Original Message-----
> From: James Molloy 
> Sent: 19 April 2012 16:22
> To: cfe-commits at cs.uiuc.edu
> Subject: FW: [cfe-commits] [PATCH] Driver: Unify CC1Options.td and
> Options.td, take 2!
> Bump.
> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu
> [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of James Molloy
> Sent: 18 April 2012 14:42
> To: cfe-commits at cs.uiuc.edu
> Subject: [cfe-commits] [PATCH] Driver: Unify CC1Options.td and Options.td,
> take 2!
> Hi,
> Now that the LLVM conference is out of the way I can get back to my other
> project that took a bit of a backseat, sorting out the clang driver.
> I sent this patch upstream at the start of February, and it was about to
> complete code review and signoff when Chandler went away on vacation for
> ages and then afterwards I had the conference so it's been gathering dust
> my patch queue for a good 2 months.
> I've rebased it to ToT and would like to have it reviewed now please :)
> Original message thread at
> tml , with the last message here:
> tml 
> The original message says it better, but essentially this patch removes
> duplication between CC1Options.td and Options.td, and removes the
> separation. This is one step in the path of removing the option forwarding
> from the driver for Clang and relying on CompilerInvocation for all option
> [de]serialization.
> Chandler had some review comments, and my responses to those still stand
> (the main one being I'll provide a followup patch to move CC1-only options
> from Options.td to CC1Options.td).
> Cheers!
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

More information about the cfe-commits mailing list