[cfe-commits] [PATCH] move a non portable test to FileCheck
jsg at jsg.id.au
Tue May 1 00:19:23 PDT 2012
On Mon, Apr 30, 2012 at 07:04:46PM -0700, Douglas Gregor wrote:
> On Apr 30, 2012, at 7:02 PM, Chandler Carruth <chandlerc at google.com> wrote:
> > On Mon, Apr 30, 2012 at 6:43 PM, Douglas Gregor <dgregor at apple.com> wrote:
> > On Mar 21, 2012, at 3:07 AM, Jonathan Gray <jsg at jsg.id.au> wrote:
> > > In test/Driver/clang-g-opts.c with tests of the form
> > >
> > > // RUN: %clang -S -v -o %t %s 2>&1 | not grep -w -- -g
> > >
> > > using 'not' here isn't portable and doesn't work on at least
> > > OpenBSD and likely other systems (bash builtin?).
> > >
> > > patch to move this to FileCheck attached
> > Committed as r155874, thanks!
> > See my comments on the commit, I don't think this is a correct patch.
> > Move-over, 'not' *is* portable, as we build the 'not' command out of the LLVM tree?
> > I fully support moving it to filecheck, but the reason as stated doesn't comute for me.
> And? I completely misread the patch. Reverted in r155878.
> - Doug
I don't follow why this was reverted, could someone explain the reasoning?
Before the diff the test fails when it shouldn't have.
More information about the cfe-commits