[cfe-commits] [PATCH] "-gline-tables-only" flag for Clang

Eric Christopher echristo at apple.com
Sat Apr 28 16:07:00 PDT 2012


> 
> Sending the revised (modulo r155697) patch. Please take a look.
> 
> Codereview: http://codereview.appspot.com/6112056/#ps9001

I think about the only comment I've got is whether or not we should use comparison operators instead of == and != in these sorts of cases?

-    Dbg->EmitGlobalVariable(E->getDecl(), Init);
+    if (CGM.getCodeGenOpts().DebugInfo != CodeGenOptions::DebugLineTablesOnly)
+      Dbg->EmitGlobalVariable(E->getDecl(), Init);

I'd prefer it personally. Your thoughts?

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120428/a7dc748e/attachment.html>


More information about the cfe-commits mailing list