[cfe-commits] [patch] Make the "unexpected ':'" warning faster to parse

Nico Weber thakis at chromium.org
Fri Apr 27 14:29:52 PDT 2012


Hi,

the attached patch changes

  test.cc:4:11: error: unexpected ':' in nested name specifier
    return A:a;
            ^
            ::
  1 error generated.

to

  test.cc:4:11: error: unexpected ':' in nested name specifier, did
you mean '::'?
    return A:a;
            ^
            ::
  1 error generated.


True, there's a fixit for the '::' already, but it always takes me a
second to see that. One coworker asked for the same change. Is this
change ok? (The diagnostic is only used in one place, and always shows
the '::' fixit.)

Nico
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-colon.patch
Type: application/octet-stream
Size: 651 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120427/7f7efe78/attachment.obj>


More information about the cfe-commits mailing list