[cfe-commits] [PATCH] Implicit fall-through between switch labels

[Alexander Kornienko]

Hello,

The new version of patch addresses most of the issues discussed here +
refactored code ;)

On Tue, Apr 24, 2012 at 7:52 PM, Chandler Carruth <chandlerc at google.com>wrote:

> On Tue, Apr 24, 2012 at 10:39 AM, Richard Smith <richard at metafoo.co.uk>wrote:
>
>> On Tue, Apr 24, 2012 at 9:37 AM, Jordy Rose <jediknil at belkadan.com>wrote:
>>
>>> And again I think the fixit (and perhaps the message) should use GCC
>>> __attribute__ syntax if we're not in C++11 mode.
>>
>>
>> GNU attributes can't be attached to statements. Do we want to diverge
>> from the GNU attribute spec (such as it is) for this? (I'm not saying no --
>> I think having this outside C++11 would be awesome -- but this gives me
>> pause).
>>
>
> Personally, I have no particular motivation to expose this outside of
> C++11. Yet another reason to migrate to C++11. ;]
>
> If we're going to do it, I would do it by making C++11 attributes (or some
> subset) available as an extension in C++98 mode.
>

Can gcc-style attributes be applied to statements at all? I doubt.

-- 
Best regards,
Alexander Kornienko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120425/1caa5396/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: switch-implicit-fallthrough3.diff
Type: application/octet-stream
Size: 18550 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120425/1caa5396/attachment.obj>