[cfe-commits] [PATCH] make __builtin_annotation generic

Xi Wang xi.wang at gmail.com
Tue Apr 24 11:51:13 PDT 2012


On Apr 24, 2012, at 2:34 PM, Julien Lerouge wrote:
> 
> Looks good to me. Thanks.
> 
> The only thing I'd be worried about is that this could break current
> users of those annotations who expect the casts (although it would be an
> easy fix). That's the reason why I kept the casts when I backported this
> thing from llvm-gcc.

Hi Julien,

Thanks for reviewing.

I agree with the compatibility concern.  Hope people will like the
patch since now it's way easier to extract the annotation (as well
as a correct semantics compared to the odd truncation-extension).

> I'll apply your patch (unless you have commit access?).

No, I don't.  Thanks a lot for the help.

- xi




More information about the cfe-commits mailing list