[cfe-commits] [Microsoft C++ ABI] Add initial support for array cookies

Timur Iskhodzhanov timurrrr at google.com
Mon Apr 23 07:14:02 PDT 2012


Hi John,

Can you please review the attached patch?
It allows compiling "delete [] array;" code.
It works exactly as the VS-generated cookies, except for the most
simple case when the array is used for a type without a destructor
(see the related FIXME in the test).
Still, this initial support is much better than the "not supported"
stub we have now.
I'll file a bug against myself to fix this difference after committing.

Please note that this patch assumes that the other patch I've sent for
review to you is commited
(see "[Microsoft ABI change review] Fix a null deref on operator
new/delete mangling")
so I won't commit bug_12333.patch before bug_12332_X.patch

Looking forward for your comments!

Thanks,
Timur Iskhodzhanov,
Google Russia
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_12333.patch
Type: application/octet-stream
Size: 8763 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120423/077c2b39/attachment.obj>


More information about the cfe-commits mailing list