[cfe-commits] SmallVectorImpl visualizer for Visual Studio

[David Blaikie]

On Thu, Apr 19, 2012 at 10:31 AM, Nikola Smiljanic <popizdeh at gmail.com> wrote:
> That would work but you would have to expand SmallVector once to see
> the base class and one more time to activate the visualizer for
> SmallVectorImpl, this approach saves one click :)

Oh, yeah - I don't want to make it any different to use - I was just
wondering what the right way to remove the redundancy in the
visualizer descriptions without changing the behavior was (if there is
a way to do that). Just a thought.

- David

>
> On Thu, Apr 19, 2012 at 7:28 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> On Thu, Apr 19, 2012 at 10:17 AM, Nikola Smiljanic <popizdeh at gmail.com> wrote:
>>> Please commit.
>>
>> Committed as r155140. Thanks for the patch.
>>
>> I don't have VS available to verify this - but it looks like a simple
>> enough copy/paste from the SmallVector<T, N> visualizer. I wonder
>> whether the two can be coalesced in some way? (what happens if you
>> have a visualizer for a base class and none for a derived class? Does
>> it just use the base visualizer? in that case we could just remove the
>> SmallVector<T, N> version entirely)
>>
>> - David