[cfe-commits] FW: [PATCH] Driver: Unify CC1Options.td and Options.td, take 2!

James Molloy James.Molloy at arm.com
Thu Apr 19 08:22:11 PDT 2012


Bump.

-----Original Message-----
From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of James Molloy
Sent: 18 April 2012 14:42
To: cfe-commits at cs.uiuc.edu
Subject: [cfe-commits] [PATCH] Driver: Unify CC1Options.td and Options.td, take 2!

Hi,

Now that the LLVM conference is out of the way I can get back to my other
project that took a bit of a backseat, sorting out the clang driver.

I sent this patch upstream at the start of February, and it was about to
complete code review and signoff when Chandler went away on vacation for
ages and then afterwards I had the conference so it's been gathering dust in
my patch queue for a good 2 months.

I've rebased it to ToT and would like to have it reviewed now please :)

Original message thread at
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120123/052089.h
tml , with the last message here:
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120123/052094.h
tml

The original message says it better, but essentially this patch removes the
duplication between CC1Options.td and Options.td, and removes the namespace
separation. This is one step in the path of removing the option forwarding
from the driver for Clang and relying on CompilerInvocation for all option
[de]serialization.

Chandler had some review comments, and my responses to those still stand
(the main one being I'll provide a followup patch to move CC1-only options
from Options.td to CC1Options.td).

Cheers!

James

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unify-cc1options.reduced.diff
Type: application/octet-stream
Size: 18630 bytes
Desc: unify-cc1options.reduced.diff
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120419/21c5356d/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unify-cc1options.full.diff
Type: application/octet-stream
Size: 103161 bytes
Desc: unify-cc1options.full.diff
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120419/21c5356d/attachment-0001.obj>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ATT00001..txt
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120419/21c5356d/attachment.txt>


More information about the cfe-commits mailing list