[cfe-commits] [PATCH] Adds a RecursiveASTVisitor test

[Erik Verbruggen]

On 18 apr. 2012, at 16:40, Manuel Klimek <klimek at google.com> wrote:

> Hi,
> 
> the attached patch adds a test for RAV based on the tooling
> infrastructure. It also includes some FIXME tests which require fixes
> in RAV itself / the AST and which are basically impossible to test
> with an integration level test.
> 
> Some of the classes at the beginning in the file are probably going to
> be pulled out when other tests want to use them (for example, in the
> tooling branch I use the TestVisitor for tests of the refactoring
> library). I have no idea where to pull them though, and wanted to get
> feedback on the general idea first. My general feeling is that it's
> still too much overhead to pull out a test like this, but I'd rather
> have smaller steps here than overarchitect a solution.
> 
> Thoughts?
> 
> /Manuel
> <ravtest.patch>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Nit-pick remark: the brief description of ExpectedLocationVisitor is a *bit* self-referencing. Otherwise, LGTM.

-- Erik.