[cfe-commits] [Microsoft ABI change review] Fix a null deref on operator new/delete mangling

[Timur Iskhodzhanov]

Anton,

I wonder if you could review this patch?

Thanks,
Timur Iskhodzhanov,
Google Russia




On Mon, Apr 16, 2012 at 8:18 PM, Timur Iskhodzhanov <timurrrr at google.com> wrote:
> Hi Charles, John,
>
> I've gone forward and created a patch which seems to fix the issue.
> I've also added some tests to make sure we don't regress in the future.
> The other tests passed just fine.
>
> Can you please take a look?
> Please note I'm not very familiar with the codebase so I'd happy to
> change something if you think I'm doing it wrong.
>
> Thanks in advance!
> Timur Iskhodzhanov
>
> On Thu, Apr 12, 2012 at 6:08 PM, Timur Iskhodzhanov <timurrrr at google.com> wrote:
>> Sorry, here's the correct patch
>> (forgot to copy-paste {} from the other checkout)
>>
>> On Thu, Apr 12, 2012 at 5:51 PM, Timur Iskhodzhanov <timurrrr at google.com> wrote:
>>> Hi Charles, John,
>>>
>>> Can you please review this small patch?
>>> See http://llvm.org/bugs/show_bug.cgi?id=12332 -> I think an informed
>>> assert() is better than a segmentation fault stack.
>>>
>>> Thanks!
>>> Timur Iskhodzhanov,
>>> Google Russia