[cfe-commits] r154749 - in /cfe/trunk: lib/AST/Decl.cpp test/CodeGenCXX/visibility.cpp

Rafael Espíndola rafael.espindola at gmail.com
Mon Apr 16 11:49:08 PDT 2012


> I understand the desire to fix bugs, but this is a very subtle change with
> poorly-understood repercussions, and it was made two days before
> branch.  Please revert this, and we can talk about your more principled
> design for visibility calculation (which looks very good!) as a post-3.1
> thing.

I reverted it in 154846. I left the refactoring patches in.

If at all possible I would like to propose the visibility changes to
3.1. The particular case in PR12552 was extracted from a mozilla test
that failed with clang.

> John.

Cheers,
Rafael




More information about the cfe-commits mailing list