[cfe-commits] [PATCH] C++ 11 statement attributes + switch labels fall-through detection

[Alexander Kornienko]

Hi Richard,

Thanks for the review. The next patch is attached. It addresses issues you
pointed out, and doxygen comments style (thanks to Chandler).

I've also added a separate diagnostic message for wrong attributes used on
statements, and a test for it. These require some work in
Parser::ParseCXX0XAttributeSpecifier (which I didn't touch yet).

Please, review this patch.

Thanks!

On Fri, Apr 6, 2012 at 12:26 AM, Richard Smith <richard at metafoo.co.uk>wrote:

> On Thu, Apr 5, 2012 at 3:23 PM, Richard Smith <richard at metafoo.co.uk>wrote:
>
>> Hi Alex,
>>
>> I think the patch is generally looking pretty good. All of your TODOs
>> seem like reasonable things to defer to later patches. I have some specific
>> comments below (mostly formatting-related):
>>
>
> Oh, and -- it would be great if you can come up with some way to test
> these changes. I appreciate that's going to be difficult since we don't
> accept any statement attributes yet, but you should at least be able to
> test that declaration attributes are rejected when applied to statements.
>



-- 
Regards,
Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120413/c4562529/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: stmt-attributes7.diff
Type: application/octet-stream
Size: 47491 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120413/c4562529/attachment.obj>