[cfe-commits] Fix handling of ARM homogenous aggregates

Anton Korobeynikov anton at korobeynikov.info
Mon Apr 9 07:03:59 PDT 2012


Hi Bob et al

Attached patch addresses the following issues:

> * More seriously, I don't see how you can get away with asserting on unions in CodeGenFunction::ExpandTypeFromArgs.  Am I missing something?
> * I don't much like the code duplication for the "expand a field" code in ExpandTypeToArgs.  If you can get away with just grabbing the first field of a union, I think you could unify that into a single loop over the fields and just exit after the first iteration in the case of a union.  Otherwise, maybe you could factor that code out into a separate function.

I do not attach the testcases once again here just to simplify the patch :)

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University
-------------- next part --------------
A non-text attachment was scrubbed...
Name: arm-homogenous-agg.patch
Type: application/octet-stream
Size: 11346 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120409/17ccedb4/attachment.obj>


More information about the cfe-commits mailing list