[cfe-commits] r154198 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp test/SemaCXX/warn-thread-safety-parsing.cpp

[Delesley Hutchins]

Consistency.  Everything reported by the thread safety analysis is
supposed to be a warning.  The only actual errors you should get are
caused by syntax errors in the lock expressions.  For example, if you
forget to annotate a function with exclusive_locks_required, then you
get a warning.  But if you forget to annotate a class with lockable,
then you previously got an error, which didn't match the behavior of
the rest of the system.

  -DeLesley

On Fri, Apr 6, 2012 at 1:12 PM, Chandler Carruth <chandlerc at google.com> wrote:
> On Fri, Apr 6, 2012 at 10:02 PM, DeLesley Hutchins <delesley at google.com>
> wrote:
>>
>> Thread safety analysis: downgraded requirement that mutex expressions
>> refer to a lockable type from error to warning.
>
>
> Why? this seems a surprising move.



-- 
DeLesley Hutchins | Software Engineer | delesley at google.com | 505-206-0315