[cfe-commits] [PATCH] NSOrderedSet support for static analyzer's BasicObjCFoundationChecks

Jordan Rose jediknil at belkadan.com
Fri Apr 6 12:07:46 PDT 2012


Thanks, Sean. You had one small mistake overwriting an additional selector unnecessarily, but other than that it looks good. Fixed and committed as r154194.

Jordy


On Apr 5, 2012, at 15:11, Sean McBride wrote:

> Hi all,
> 
> This is my first post to this list.  If I understand right, this is where patches should be sent for review?  Do I need to create a bug entry too?
> 
> Anyway, attached is a patch for the static analyzer's BasicObjCFoundationChecks.cpp.  It adds checks for 10.7's NSOrderedSet.  Honestly, I don't know what I'm doing here, and was only able to create this patch by following the established pattern.  :)  You should review carefully. :)
> 
> Cheers,
> 
> --
> ____________________________________________________________
> Sean McBride, B. Eng                 sean at rogue-research.com
> Rogue Research                        www.rogue-research.com
> Mac Software Developer              Montréal, Québec, Canada
> <NSOrderedSet.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits





More information about the cfe-commits mailing list