[cfe-commits] [PATCH] C++ 11 statement attributes + switch labels fall-through detection

Alexander Kornienko alexfh at google.com
Wed Apr 4 16:18:14 PDT 2012

Hi Chandler,

You are right, it's better to separate apples from oranges. Here's a patch
for statement attributes implementation. I'll post the rest after dealing
with this one.

On Wed, Apr 4, 2012 at 3:46 PM, Chandler Carruth <chandlerc at google.com>wrote:

> I've not looked at the patch yet, but to make reviewing easier:
> On Wed, Apr 4, 2012 at 11:01 PM, Alexander Kornienko <alexfh at google.com>wrote:
>> I've also implemented one specific statement attribute as an example
> Can you please split the generic statement attribute work and the new
> attribute into two patches? These should be reviewed independently. One is
> a step toward support of a standard feature, the other is a brand new
> language extension. These have very different code review paths.

Alexander Kornienko | Software Engineer | alexfh at google.com | +49 151 221
77 957
Google Germany GmbH | Dienerstr. 12 | 80331 München

AG Hamburg, HRB 86891 | Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens

Tax ID:- 48/725/00206
VAT ID:- DE813741370
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120404/9956aa8e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: stmt-attributes3.diff
Type: application/octet-stream
Size: 90185 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120404/9956aa8e/attachment.obj>

More information about the cfe-commits mailing list