[cfe-commits] [PATCH] -rewrite-includes

Lubos Lunak l.lunak at suse.cz
Wed Apr 4 03:44:21 PDT 2012


On Wednesday 04 of April 2012, Matt Beaumont-Gay wrote:
> Looking better.
[list of improvements and "improvements" skipped]

 You know what, I give up. This is ridiculous and I've had enough.

 Although I have spent quite some time on the patch and really don't like the 
idea of not upstreaming it and keeping it only for me and whoever else would 
be interested, I like even less the idea of going through one more iteration 
of this. I don't think I've ever been treated even close to this when 
submitting a patch to any of the other projects I've sent a patch to. If you 
don't want the feature and a possible contributor, you could have just as 
well said it right at the beginning.

 If somebody with superpowers sufficient to get past this inquisition session 
would feel like taking over the patch, just go ahead. I don't think there's 
any technical problem with it and I've been using it extensively in the last 
few weeks (and I'd be willing to have a look at it if somebody finds an 
actual technical problem in it after all).

 This has been a good example to me of how not to treat patch submissions from 
possible new contributors and I'll make sure to keep it in mind when 
accepting patches for the projects I care for, so thanks at least for the 
lesson.

-- 
 Lubos Lunak
 l.lunak at suse.cz



More information about the cfe-commits mailing list