[cfe-commits] Please review: add tbaa metadata to vtable pointer loads/stores

Kostya Serebryany kcc at google.com
Mon Mar 26 10:04:11 PDT 2012


r153447, thank you!
--kcc

On Mon, Mar 26, 2012 at 9:25 AM, John McCall <rjmccall at apple.com> wrote:

> On Mar 22, 2012, at 6:40 PM, Chandler Carruth wrote:
>
> On Thu, Mar 22, 2012 at 5:49 PM, Kostya Serebryany <kcc at google.com> wrote:
>
>> Hello,
>>
>> Please review the following patch which adds tbaa metadata nodes to
>> vtable pointer loads/stores.
>> These metadata nodes will be immediately useful for ThreadSanitizer
>> instrumentation (it needs to treat vtable updates in a special way).
>> They may also help various optimization phases that use the tbaa
>> information.
>> http://codereview.appspot.com/5881053
>>
>
> The patch looks great to me, but you should wait for one of the Clang
> IRGen folks to look at it before submitting.
>
>
> It looks fine to me.
>
> John.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120326/283de280/attachment.html>


More information about the cfe-commits mailing list