[cfe-commits] r153369 - in /cfe/trunk: include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h lib/StaticAnalyzer/Checkers/MallocChecker.cpp lib/StaticAnalyzer/Core/BugReporter.cpp

[Ted Kremenek]

On Mar 24, 2012, at 7:58 PM, Jordan Rose <jediknil at belkadan.com> wrote:

> 
> On Mar 24, 2012, at 19:37, Ted Kremenek wrote:
> 
>> On Mar 23, 2012, at 8:03 PM, Jordy Rose <jediknil at belkadan.com> wrote:
>> 
>>> Author: jrose
>>> Date: Fri Mar 23 22:03:29 2012
>>> New Revision: 153369
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=153369&view=rev
>>> Log:
>>> [analyzer] Restart path diagnostic generation if any of the visitors change the report configuration while walking the path.
>>> 
>>> This required adding a change count token to BugReport, but also allowed us to ditch ImmutableList as the BugReporterVisitor data type.
>> 
>> Hi Jordy,
>> 
>> Just to be clear, ditching ImmutableList is safe because we are visiting the BugReporterVisitors using a temporary list that is immutable while we are iterating over it, correct?  If a new BugReporterVisitor is created, it gets added to the original visitor set, not the one being iterated over?
>> 
>> Ted
> 
> Right! Which has the interesting result of the original BugReporterVisitors never actually being used.
> 
> Jordy

Ok awesome.