[cfe-commits] [patch] command line options for MIPS float ABI configuration

Sandeep Patel deeppatel1987 at gmail.com
Thu Mar 22 23:02:50 PDT 2012


On Fri, Mar 23, 2012 at 5:42 AM, Simon Atanasyan <satanasyan at mips.com> wrote:
> On Wed, Mar 21, 2012 at 9:53 AM, Simon Atanasyan <satanasyan at mips.com> wrote:
>> On Wed, Mar 21, 2012 at 5:52 AM, Hatanaka, Akira <ahatanaka at mips.com> wrote:
>>> The patch looks fine. Two minor issues:
>>>
>>> 1. Curly braces aren't necessary if there is just one statement:
>>
>> Fixed.
>>
>>> 2.   "+soft-float" can be found in the manually written loop. Is it necessary to call std::find?
>>
>> Fixed.
>>
>> Updated patch is attached.
>
> Ping.

LGTM.

Do other MIPS toolchains have a feature to be able to mix soft and
hard float ABIs within the same source file similar to ARM's
__attribute__((pcs("aapcs-vfp"))) ? Such a feature would be
incompatible with the macros defined here.

deep




More information about the cfe-commits mailing list