[cfe-commits] r153010 - in /cfe/trunk: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/malloc-plist.c

[Ted Kremenek]

On Mar 19, 2012, at 5:22 PM, Jordan Rose <jediknil at belkadan.com> wrote:

> On the other hand, MallocBugVisitor is currently stateful -- that is, it assumes it's never going to see the same node-pair twice, and that the nodes are always visited end-to-start. I can make it less stateful (i.e. accept the same node-pair twice), but getting it down all the way to no state means a fair amount of rewriting. Is it part of the design that visitors be non-stateful, in case we ever want to traverse the nodes in some other order?

Hmm.  What about make the state functional, and having that state maintained by BugReporter as we walk the path?  We could then generate state speculatively, and throw it away when we don't care.  Just a half baked idea, that I haven't necessarily thought through.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120319/29d47569/attachment.html>