[cfe-commits] [PATCH] More recursive visit removals
kremenek at apple.com
Thu Mar 15 10:22:40 PDT 2012
On Mar 14, 2012, at 12:34 PM, Jordan Rose <jediknil at belkadan.com> wrote:
> On Mar 14, 2012, at 11:09, Erik Verbruggen wrote:
>> On Mar 14, 2012, at 18:22, Anna Zaks wrote:
>>> (After looking at the code briefly, I am not sure if AggExprVisitor is needed at all. It looks like it's main purpose is to perform recursive visitation..)
>> Neither am I, but I don't feel confident enough to just kill it.
>> -- Erik.
> I would be. The only actual work it's doing is passing the new object region to the evaluation of CXXConstructExpr, and we do that already now. (And don't use it for anything, for that matter.) It's probably better to take it out now rather than leave it lying around and have someone mistakenly try to hook it up again.
Agreed. We can remove AggExprVisitor.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits