[cfe-commits] [PATCH] More recursive visit removals
erikjv at me.com
Wed Mar 14 10:09:23 PDT 2012
On 14 mrt. 2012, at 17:57, Anna Zaks <ganna at apple.com> wrote:
> On Mar 14, 2012, at 8:18 AM, Erik Verbruggen wrote:
>> Attached is probably the last one in the series.
> The patch looks good.
>> After that patch, there are two calls to ExprEngine::Visit left. One is in ExprEngine::ProcessStmt, but will have to stay there. The other one is in AggExprVisitor, called from ExprEngine::VisitAggExpr. This last one is only called from disabled code in ExprEngine::VisitCXXConstructExpr. Is it safe to remove this code too?
> I'd keep the dead code. Looks like it's the C++ support which is just waiting to be improved and productized.
Should I commit the patch as-is, or add a comment that the recursive visit should be removed in the future?
>> -- Erik.
>> On Mar 14, 2012, at 1:21, Ted Kremenek wrote:
>>> On Mar 5, 2012, at 4:09 AM, Erik Verbruggen <erikjv at me.com> wrote:
>>>> This time in the VisitCXXConstructExpr method.
>>>> -- Erik.
>>>> cfe-commits mailing list
>>>> cfe-commits at cs.uiuc.edu
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
More information about the cfe-commits