[cfe-commits] Use GCC_INSTALL_PREFIX to initialize SysRoot
rafael.espindola at gmail.com
Sat Mar 10 11:22:11 PST 2012
On the clang patch:
Typo: Retunrs in
/// Retunrs the sysroot path after removing the trailing /.
+ #include "clang/Config/config.h"
This should be with the other includes
getSysRoot is returning a StringRef to a deleted object, no? Probably
the best is to avoid using SmallString in Compilation::getSysRoot
(which unfortunately means not using
The getSysRoot code is duplicated inline in Driver::BuildCompilation, no?
On the llvm patch:
GCC_INSTALL_PREFIX and DEFAULT_SYSROOT can go in the clang CMakeFile,
no? (thanks for adding GCC_INSTALL_PREFIX!).
More information about the cfe-commits