[cfe-commits] [llvm-commits] Fix bug 12212 Missing mul-to-shift conversion for negative non-power-of 2 constants on ARM

Anton Korobeynikov anton at korobeynikov.info
Fri Mar 9 02:20:12 PST 2012


> Please review it.
Generally looks good. Two nit-picks:
1. Make sure your code style matches the style of surrounding code
(here, in particular - the newlines before / after "{" and "}")
2. I don't think you need separate MulAmtAbs variable - after all,
later you have if() basing on the sign of MulAmtAbs, so, you can just
fold the proper absolute value inside the branches of if()

Thanks for working on this!
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University

More information about the cfe-commits mailing list