[cfe-commits] r152271 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/AnalysisBasedWarnings.cpp test/FixIt/fixit-recursive-block.c

[jahanian]

On Mar 7, 2012, at 4:42 PM, Jordan Rose wrote:

> 
> On Mar 7, 2012, at 16:22, Fariborz Jahanian wrote:
> 
>> Author: fjahanian
>> Date: Wed Mar  7 18:22:50 2012
>> New Revision: 152271
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=152271&view=rev
>> Log:
>> improve on diagnostic and provide a fixit hint when
>> an uninitialized block variable is being called inside the
>> block literal. // rdar://10817031
>> 
> 
> I'm not a fan of the fixit wording... __block doesn't "silence" the warning, it changes the semantics. Admittedly, the original semantics are wrong and this is almost certainly the right fix, but it is a real change. How about something like "maybe you meant to use __block?"

I can't think of anything better than your suggestion.
In r152273.

- Fariborz