[cfe-commits] Use GCC_INSTALL_PREFIX to initialize SysRoot

[James Molloy]

Hi Sebastian,

It mostly LGTM, but I don't think you've added a CMake cache variable for
DEFAULT_SYSROOT. You've added it to the config.h.cmake, but not to the
CMakeLists.txt so it can't actually be set.

Cheers,

James

-----Original Message-----
From: Sebastian Pop [mailto:spop at codeaurora.org] 
Sent: 06 March 2012 22:42
To: cfe-commits at cs.uiuc.edu
Cc: Chandler Carruth; Rafael Espíndola; Joerg Sonnenberger; James Molloy
Subject: Re: Use GCC_INSTALL_PREFIX to initialize SysRoot

Hi,

Sorry for having misspelled the mailing list address in my previous emails.

Here is the amended patch with the comments from Joerg and Rafael.
The patch adds a configure flag --with-default-sysroot that will set the
default value of the clang flag --sysroot.  The configure time flag name
has been intentionally renamed from --with-sysroot in order to avoid
confusion with the semantics of this flag in the gcc configure.

Please review and let me know how I can improve this patch.

Joerg, concerning your remark:
> My question still stands. Do you want to emulate the (IMO insane) GCC
> configure option or just provide a default value for --sysroot. If the

The patch intends to provide a default value to --sysroot: I do not want
to emulate the semantics of GCC's configure flag.

> latter, the option should be named differently to avoid confusion.
> I don't think this patch really implements this behavior though.

Please let me know if this current patch addresses your concerns.

Thanks,
Sebastian

On Mon, Mar 5, 2012 at 3:46 PM, Sebastian Pop <spop at codeaurora.org> wrote:
> Hi,
>
> Ping: could you please review the attached patches?
> These are adding a configure time flag for a flag accepted by clang at
> compile time.
> When the configure time flag is set, it will serve as the default value.
>
> Thanks,
> Sebastian
>
> On Thu, Feb 9, 2012 at 2:28 PM, Sebastian Pop <spop at codeaurora.org> wrote:
>> On Thu, Feb 9, 2012 at 12:42 PM, Sebastian Pop <spop at codeaurora.org>
wrote:
>>> As there is no way to specify a --sysroot= at configure time, what
>>> about adding the configure flag --with-sysroot and initialize sysroot
>>> from there if clang has not been passed a --sysroot= flag?
>>
>> This is implemented in the attached patches.
>>

--
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum