[cfe-commits] [PATCH] Mangler does not mangle extern "C"'d symbols in ::std correctly

James Molloy James.Molloy at arm.com
Mon Mar 5 02:05:27 PST 2012

Hi Eli,

Thanks. I've committed it (plus the test) in r152022.

I had forgotten to svn add before svn diffing when I applied the patch to a fresh ToT checkout.



-----Original Message-----
From: Eli Friedman [mailto:eli.friedman at gmail.com]
Sent: 02 March 2012 20:00
To: James Molloy
Cc: cfe-commits at cs.uiuc.edu
Subject: Re: [cfe-commits] [PATCH] Mangler does not mangle extern "C"'d symbols in ::std correctly

On Fri, Mar 2, 2012 at 7:08 AM, James Molloy <james.molloy at arm.com> wrote:
> Hi,
> The attached patch fixes a bug in which a name in namespace ::std which is
> within an extern "C" {} block* would not be mangled correctly. The patch
> itself is simple, and comes from the lack of a call to
> IgnoreLinkageSpecDecls().
> As part of general code smell I have also moved two other places where
> IgnoreLinkageSpecDecls()'s functionality was being duplicated to using that
> function.
> Regression test attached. Is it OK to commit?

I don't see the regression test... but otherwise, patch looks fine.


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.

More information about the cfe-commits mailing list